Fixed: Drag and Drop Causes Flashing and Disappearing Cards

[rksingh2001]

Issue was "inView" was setting false due to root being scrollWrapper, instead changed it to viewport.
Fixes: #6001
Screencast from 2024-06-27 22-50-59.webm

[greptile-apps]

PR Summary

• Modified useInView hook to use viewport as root instead of scrollWrapper
• Fixed issue causing cards to flash and disappear during drag and drop

_{1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings}

[charlesBochet]

Hi @rksingh2001, thanks for your PR :) I'm not sure about this fix. I would expect an optimistic rendering issue (there is a concurrency issue between the queries behind each column / the cache is not properly updated).

Let's have a closer look to your fix tomorrow

[rksingh2001]

Hi @rksingh2001, thanks for your PR :) I'm not sure about this fix. I would expect an optimistic rendering issue (there is a concurrency issue between the queries behind each column / the cache is not properly updated).

Let's have a closer look to your fix tomorrow

Sure, @charlesBochet, its still optimistic rendering, its just that the root is now viewport. Although I don't full understand this point -> (there is a concurrency issue between the queries behind each column / the cache is not properly updated).

[lucasbordeau]

Hi @rksingh2001, could you please look into the logic that updates a board card position in DB, because the problem is that now that we have one Apollo request per column, there's something that is not working with optimistic rendering in Apollo cache.

Here it shouldn't take so long to update a board card visually (but it's ok if the request is slow) and should be instantaneous, with the help of optimistic rendering.

Also we shouldn't try to fix the content of the card disappearing in this issue as it is not our concern here.

[rksingh2001]

@lucasbordeau "there's something that is not working with optimistic rendering in Apollo cache", can you be a little more specific on what exactly is not working, so I understand better.

"Also we shouldn't try to fix the content of the card disappearing in this issue as it is not our concern here." <- I don't understand this part, do we not need to fix #6001? Because then there is no need of this PR.