Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: message cleaner drop repository #6052

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

magrinj
Copy link
Member

@magrinj magrinj commented Jun 27, 2024

This PR use the new TwentyORM for the message-cleaner module by using the new injection system with @InjectWorkspaceRepository.

@magrinj magrinj marked this pull request as ready for review June 27, 2024 08:00
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

  • Replaced ObjectMetadataRepositoryModule with TwentyORMModule in messaging-message-cleaner.module.ts
  • Updated repository injection to use @InjectWorkspaceRepository in messaging-message-cleaner.service.ts
  • Aligned message and thread fetching/deletion methods with new repository structure

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

(updates since last review)

  • Updated Processor decorator in messaging-blocklist-item-delete-messages.job.ts to include scope and queueName
  • Updated Processor decorator in messaging-connected-account-deletion-cleanup.job.ts to include Scope.REQUEST

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant