Create fields for calendar and messaging settings v2 #6049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
- Added new standard field IDs for calendar and messaging settings
- Introduced
contactAutoCreationfield toCalendarChannelWorkspaceEntity - Added
contactAutoCreation,excludeNonProfessionalEmails, andexcludeGroupEmailsfields toMessageChannelWorkspaceEntity - Deprecated
isContactAutoCreationEnabledfield in messaging settings - Updated enums for contact auto-creation and sync stages in messaging settings
3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
...ges/twenty-server/src/modules/calendar/standard-objects/calendar-channel.workspace-entity.ts
Outdated
Show resolved
Hide resolved
...nty-server/src/modules/messaging/common/standard-objects/message-channel.workspace-entity.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Updated default value for
contactAutoCreationincalendar-channel.workspace-entity.ts - Ensured
contactAutoCreationandsyncStagedefaults are strings inmessage-channel.workspace-entity.ts
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Renamed
contactAutoCreationtocontactAutoCreationPolicyinstandard-field-ids.ts - Updated
CalendarChannelContactAutoCreationtoCalendarChannelContactAutoCreationPolicyincalendar-channel.workspace-entity.ts - Renamed
MessageChannelContactAutoCreationtoMessageChannelContactAutoCreationPolicyinmessage-channel.workspace-entity.ts - Ensured consistency and clarity in naming conventions for contact auto-creation policies
3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Weiko
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create fields for calendar and messaging settings v2