5901 refactor email and calendar auto contact creation to create them by batch #6038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
- Added
@types/lodash.chunkandlodash.chunkdependencies - Introduced
CONTACTS_CREATION_BATCH_SIZEconstant - Deleted
messaging-message-channel.listener.ts - Refactored
create-company-and-contact.service.tsto handle batch processing - Updated type definitions from
ContactstoContact[]across multiple files
9 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
Comment on lines
45
to
49
| objectRecordChangedProperties( | ||
| payload.properties.before, | ||
| payload.properties.after, | ||
| ).includes('isContactAutoCreationEnabled') && | ||
| payload.properties.after.isContactAutoCreationEnabled |
There was a problem hiding this comment.
🪶 style: Consider adding error handling for the case where 'objectRecordChangedProperties' fails or returns unexpected results.
Weiko
approved these changes
Jun 26, 2024
...saging/message-import-manager/listeners/messaging-import-manager-message-channel.listener.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Added
AutoCompaniesAndContactsCreationMessageChannelListenerto providers - Introduced listener for
messageChannel.updatedevent - Batched creation of companies and contacts for efficiency
- Removed
messageChannel.updatedlistener frommessaging-import-manager-message-channel.listener.ts - Focused
messaging-import-manager-message-channel.listener.tsonmessageChannel.deletedevent for cache cleaning
3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
…t-creation-to-create-them-by-batch
bosiraphael
deleted the
5901-refactor-email-and-calendar-auto-contact-creation-to-create-them-by-batch
branch
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Refactored email and calendar auto-contact creation to handle batch processing.
- Replaced
useSetRecordInStorewithuseUpsertRecordsInStoreacross multiple components for better record management. - Introduced new hooks and components for multi-record selection and handling.
- Added
WorkspaceJoinColumndecorators to various entity fields for improved join column handling. - Updated GraphQL queries and mutations to support batch operations and upsert functionality.
215 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5901