Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor messaging refresh access token #6034

Merged
merged 3 commits into from
Jun 27, 2024

Conversation

bosiraphael
Copy link
Contributor

  • Put error handling outside of refreshAndSaveAccessToken
  • return after failing to refresh access token in processMessageBatchImport
  • remove unnecessary token refresh in processMessageListFetch

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

  • Refactored refreshAndSaveAccessToken to remove error handling logic
  • Removed dependency on ConnectedAccountRepository in fetchAllMessages
  • Simplified processMessageListFetch by removing token refresh logic
  • Improved error handling in processMessageBatchImport for token refresh failures

4 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@Weiko Weiko merged commit 1a66db5 into main Jun 27, 2024
6 checks passed
@Weiko Weiko deleted the refactor-messaging-refresh-access-token branch June 27, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants