feat: Revamp navigation bar #6031
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
- Introduced
useRecordShowPagePaginationhook for record show page pagination - Added
viewBarIdprop toRecordTableandRecordTableWithWrappers - Updated
RecordTableContextPropsto includeviewBarId - Enhanced
PageHeaderwith pagination buttons and updated styles - Modified
useChipFieldDisplayto append view ID tolinkToShowPage
7 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings
| const navigateToPreviousRecord = () => { | ||
| const prevRecord = objectRecords[currentRecordPosition - 1]; | ||
| navigate( | ||
| `/object/${objectNameSingular}/${prevRecord.id}${ | ||
| viewIdQueryParam ? `?view=${viewIdQueryParam}` : '' | ||
| }`, | ||
| ); | ||
| setCurrentRecordPosition(currentRecordPosition - 1); | ||
| }; |
There was a problem hiding this comment.
🧠 logic: Ensure currentRecordPosition - 1 is within bounds before accessing objectRecords.
| const navigateToNextRecord = () => { | ||
| const nextRecord = objectRecords[currentRecordPosition + 1]; | ||
| navigate( | ||
| `/object/${objectNameSingular}/${nextRecord.id}${ | ||
| viewIdQueryParam ? `?view=${viewIdQueryParam}` : '' | ||
| }`, | ||
| ); | ||
| setCurrentRecordPosition(currentRecordPosition + 1); | ||
| }; |
There was a problem hiding this comment.
🧠 logic: Ensure currentRecordPosition + 1 is within bounds before accessing objectRecords.
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Enhanced pagination logic in
useRecordShowPagePagination.ts - Added
viewBarIdproperty to context inRecordTableCell.perf.stories.tsx - Replaced back button with close button in
PageHeader.tsx - Introduced pagination and close button in
RecordShowPage.tsx
4 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Reordered imports in
useRecordShowPagePagination.ts - Reformatted code for better readability
- Ensured correct invocation of
fetchMoreRecords - Adjusted logic for fetching more records for clarity
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Updated mock data for
peopleMock - Added new GraphQL query handler for
FindManyPeople - Improved accuracy of Storybook tests for
RecordShowPagecomponent
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Simplified
useEffectdependency array inuseRecordShowPagePagination.ts - Potential impact on pagination state management and updates
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
|
Pass view id to showpage on Kanban |
closes: #4428
Testing for fetchMoreRecords is pending, along with component tests