-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove CSS modules #6017
base: main
Are you sure you want to change the base?
Remove CSS modules #6017
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
- Removed CSS modules in favor of Linaria for styling
- Deleted CSS module files and replaced with styled components
- Updated
vite.config.ts
to include new components for Linaria - Added new TypeScript files for avatar properties and types
- Refactored theme provider to remove CSS modules and side effects
18 file(s) reviewed, no comment(s)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
(updates since last review)
- Removed CSS modules
- Updated import paths in
AvatarGroup.stories.tsx
- Moved
AvatarSize
andAvatarType
imports to type files - Removed overlapping CSS theme file
1 file(s) reviewed, no comment(s)
@lucasbordeau LGTM but I don't see node modules update in this PR? |
CSS modules were used as a first test for performance optimization.
We later found out that Linaria was a better tradeoff.
This PR removes what was implemented in CSS modules and also the CSS theme file that was created that was overlapping with the TS theme files.