Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CSS modules #6017

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Remove CSS modules #6017

wants to merge 6 commits into from

Conversation

lucasbordeau
Copy link
Contributor

@lucasbordeau lucasbordeau commented Jun 25, 2024

CSS modules were used as a first test for performance optimization.

We later found out that Linaria was a better tradeoff.

This PR removes what was implemented in CSS modules and also the CSS theme file that was created that was overlapping with the TS theme files.

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

  • Removed CSS modules in favor of Linaria for styling
  • Deleted CSS module files and replaced with styled components
  • Updated vite.config.ts to include new components for Linaria
  • Added new TypeScript files for avatar properties and types
  • Refactored theme provider to remove CSS modules and side effects

18 file(s) reviewed, no comment(s)

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

(updates since last review)

  • Removed CSS modules
  • Updated import paths in AvatarGroup.stories.tsx
  • Moved AvatarSize and AvatarType imports to type files
  • Removed overlapping CSS theme file

1 file(s) reviewed, no comment(s)

@charlesBochet
Copy link
Member

@lucasbordeau LGTM but I don't see node modules update in this PR?

Copy link

TODOs/FIXMEs:

  • // TODO: Remove recoil because we don't want it into twenty-ui and find a solution for invalid avatar urls: packages/twenty-ui/src/display/avatar/components/Avatar.tsx

Generated by 🚫 dangerJS against a98c02a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants