Use dynamic z indexes + use outline #6014
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
- Remove unused z-indexes
- Implement dynamic z-indexes based on scroll state
- Switch from border to outline for styling
- Update class names for table cell selection state
- Improve visual consistency and performance of table components
7 file(s) reviewed, no comment(s)
thomtrp
force-pushed
the
tt-remove-record-table-z-indexes
branch
from
981ea3a
to
89c1a6e
Compare
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Remove unused z-indexes
- Introduce dynamic z-indexes based on scroll state
- Switch from border to outline for styling
- Improve visual hierarchy and interaction feedback
- Enhance table rendering performance and consistency
7 file(s) reviewed, no comment(s)
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Remove unused z-indexes
- Introduce dynamic z-indexes based on scroll state
- Replace border usage with outline
- Add
isScrolledLeftSelectorandisScrolledTopSelectorfor scroll state detection - Improve visual handling of table headers and cells when scrolled
4 file(s) reviewed, no comment(s)
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Remove unused z-indexes
- Implement dynamic z-indexes based on scroll state
- Replace borders with outlines for styling
- Simplify
RecordTablecomponent by removingisScrolledTopprop and related logic - Ensure no visual regressions due to styling changes
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Remove unused z-indexes
- Implement dynamic z-indexes based on scroll state
- Replace borders with outlines
- Simplify
RecordTablecomponent logic - Adjust z-index of first three columns dynamically in
DraggableTableBody
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
|
Tested locally and I have a few issues on the table view 🤔 Looks like the hover is not triggered in the first cell for some reason |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5658
Enregistrement.de.l.ecran.2024-06-25.a.14.07.40.mov