fix: navigate with arrow keys in select/multi-select #5983
+64
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
- Added arrow key navigation support in
ObjectFilterDropdownRecordSelect.tsx - Integrated
SelectableListcomponent inMultipleRecordSelectDropdown.tsx - Managed selected item state using Recoil in
MultipleRecordSelectDropdown.tsx - Applied background color for
isKeySelectedprop inStyledMenuItemBase.tsx
3 file(s) reviewed, no comment(s)
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Introduced
RelationFiltertype for enhanced GraphQL filtering - Added
isEmptyOperandsupport inMultipleFiltersDropdownContent.tsx - Renamed and improved
handleOperandChangeinObjectFilterDropdownOperandSelect.tsx - Enhanced test coverage in
getOperandsForFilterType.test.tsx - Added
onSubmitprop toDateFieldInputandDateTimeFieldInputcomponents
36 file(s) reviewed, 1 comment(s)
Comment on lines
38
to
39
| ${({ isHoverBackgroundDisabled }) => | ||
| isHoverBackgroundDisabled ?? HOVER_BACKGROUND}; |
There was a problem hiding this comment.
Logical error: isHoverBackgroundDisabled should be checked for truthiness before applying HOVER_BACKGROUND.
Suggested change
| ${({ isHoverBackgroundDisabled }) => | |
| isHoverBackgroundDisabled ?? HOVER_BACKGROUND}; | |
| ${({ isHoverBackgroundDisabled }) => | |
| !isHoverBackgroundDisabled && HOVER_BACKGROUND}; |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #4977
Screen.Recording.2024-06-21.at.3.24.46.PM.mov