5095 move onboardingstatus computation from frontend to backend #5954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martmull
force-pushed
the
5095-move-onboardingstatus-computation-from-frontend-to-backend
branch
from
fa8137b
to
86afc6b
Compare
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
- Move onboarding status computation to backend
- Update hooks and states to use new backend-driven onboarding status
- Modify test cases to reflect new onboarding status values
- Remove obsolete frontend onboarding status computation logic
- Introduce
useSetNextOnboardingStatushook for consistent status updates
27 file(s) reviewed, 2 comment(s)
packages/twenty-front/src/modules/ui/layout/hooks/useShowAuthModal.ts
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/ui/layout/hooks/useShowAuthModal.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Moved
onboardingStatuscomputation from frontend to backend - Added logic to
useSetNextOnboardingStatus - Updated missing redirections in
usePageChangeEffectNavigateLocation - Simplified conditions in
useShowAuthModal.tsby removingisDefinedutility function
1 file(s) reviewed, no comment(s)
packages/twenty-front/src/hooks/usePageChangeEffectNavigateLocation.ts
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/onboarding/hooks/useSetNextOnboardingStatus.ts
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/onboarding/hooks/useSetNextOnboardingStatus.ts
Show resolved
Hide resolved
packages/twenty-server/src/modules/workspace-member/repositories/workspace-member.repository.ts
Outdated
Show resolved
Hide resolved
|
@martmull Looks way better to have this on BE. I feel we should use this opportunity to clarify workspaceStatus from subscriptionStatus from onboardingStatus. Also, I have merge main in your branch but we have some bug because of @magrinj work on typeorm. (userWorkspaceService is using scoped request but it does not seem to be properly instanciated). Could you check with him? |
packages/twenty-server/src/engine/core-modules/onboarding/onboarding.service.ts
Outdated
Show resolved
Hide resolved
martmull
force-pushed
the
5095-move-onboardingstatus-computation-from-frontend-to-backend
branch
from
f860db2
to
66f4277
Compare
martmull
force-pushed
the
5095-move-onboardingstatus-computation-from-frontend-to-backend
branch
from
7c34f54
to
a061b65
Compare
…frontend-to-backend
…frontend-to-backend
martmull
force-pushed
the
5095-move-onboardingstatus-computation-from-frontend-to-backend
branch
2 times, most recently
from
cd02091
to
dd48784
Compare
martmull
force-pushed
the
5095-move-onboardingstatus-computation-from-frontend-to-backend
branch
from
dd48784
to
a860990
Compare
martmull
force-pushed
the
5095-move-onboardingstatus-computation-from-frontend-to-backend
branch
from
a860990
to
5a40bc4
Compare
martmull
force-pushed
the
5095-move-onboardingstatus-computation-from-frontend-to-backend
branch
from
433fa31
to
9eaa2c3
Compare
charlesBochet
approved these changes
Jun 28, 2024
packages/twenty-front/src/modules/workspace/hooks/useSubscriptionStatus.ts
Outdated
Show resolved
Hide resolved
martmull
force-pushed
the
5095-move-onboardingstatus-computation-from-frontend-to-backend
branch
from
7eb4159
to
e41d498
Compare
martmull
force-pushed
the
5095-move-onboardingstatus-computation-from-frontend-to-backend
branch
from
e41d498
to
8ff17d9
Compare
martmull
deleted the
5095-move-onboardingstatus-computation-from-frontend-to-backend
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
onboardingStatuscomputing to server sideuseSetNextOnboardingStatususePageChangeEffectNavigateLocation