5748 Create contacts for emails sent and received by email aliases #5855
+446
−264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es-are-not-associated-with-the-workspacemember
…es-are-not-associated-with-the-workspacemember
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
- Introduced feature flag
IsProfileEmailsReadEnabled - Updated Google API integration to handle email aliases
- Refactored contact creation logic to include email aliases
- Added services and modules for managing email aliases and OAuth2 clients
- Enhanced message import process to support email aliases and feature flags
30 file(s) reviewed, 9 comment(s)
Comment on lines
+22
to
+26
| const featureFlag = await this.featureFlagRepository.findOneBy({ | ||
| workspaceId, | ||
| key, | ||
| value: true, | ||
| }); |
There was a problem hiding this comment.
Consider handling potential errors from the database query.
...es/twenty-server/src/engine/core-modules/feature-flag/services/is-feature-enabled.service.ts
Show resolved
Hide resolved
packages/twenty-server/src/modules/calendar/jobs/google-calendar-sync.job.ts
Outdated
Show resolved
Hide resolved
Comment on lines
+18
to
+19
| const oAuth2Client = | ||
| await this.oAuth2ClientManagerService.getOAuth2Client(connectedAccount); |
There was a problem hiding this comment.
Consider adding error handling for the OAuth2 client retrieval.
Comment on lines
+26
to
+29
| const emailsResponse = await people.people.get({ | ||
| resourceName: 'people/me', | ||
| personFields: 'emailAddresses', | ||
| }); |
There was a problem hiding this comment.
Add error handling for the API call to people.people.get to manage potential failures.
...er/src/modules/connected-account/email-alias-manager/services/email-alias-manager.service.ts
Show resolved
Hide resolved
...nnected-account/oauth2-client-manager/drivers/google/google-oauth2-client-manager.service.ts
Show resolved
Hide resolved
Comment on lines
+18
to
+21
| const oAuth2Client = new google.auth.OAuth2( | ||
| gmailClientId, | ||
| gmailClientSecret, | ||
| ); |
There was a problem hiding this comment.
Add error handling for OAuth2 client creation.
...rc/modules/connected-account/oauth2-client-manager/services/oauth2-client-manager.service.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Removed
GoogleAPIsProviderEnabledGuardfromgoogle-apis-auth.controller.ts - Introduced feature flag checks in
google-apis-oauth.guard.ts - Updated contact creation logic to include email aliases
- Deleted
google-apis-provider-enabled.guard.ts - Potential security issue:
googleAuthGetAccessTokenmethod now has no guards applied
3 file(s) reviewed, no comment(s)
…es-are-not-associated-with-the-workspacemember
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Added feature flag for email alias handling
- Updated contact creation logic to include email aliases
- Replaced custom tooltips with
AppTooltipfromtwenty-ui - Introduced new GraphQL filter types and operands
- Added unit tests for various utility functions and components
196 file(s) reviewed, no comment(s)
…es-are-not-associated-with-the-workspacemember
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5748
https://www.googleapis.com/auth/profile.emails.readwhen connecting an account