Contributing Documentation - Testing #5831
Open
+14
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Welcome!
Hello there, congrats on your first PR! We're excited to have you contributing to this project. |
|
Hi @nina-sanchez, thanks for your interest in the project. I think we should be giving more precise instruction on how to tests, rather than diving too much into the why we should add tests which is educational but one sentence should be good enough about it. I feel we should write something in the documentation instead and add a link to it from here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I am new to twenty and have been going through the documentation to better understand how to work on issues, contributing guidelines etc. As I was going through it I read that it should be tested locally - but also saw that at times testing suites were provided with the PR. Because of that I created a PR which includes information regarding testing suites when pushing, which are added into the contributing.md file. The image below shows what the section looks like when implemented: