Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When deleting permamently records, popup message must be more clear #8690

Open
BOHEUS opened this issue Nov 22, 2024 · 12 comments · May be fixed by #8864
Open

When deleting permamently records, popup message must be more clear #8690

BOHEUS opened this issue Nov 22, 2024 · 12 comments · May be fixed by #8864

Comments

@BOHEUS
Copy link
Contributor

BOHEUS commented Nov 22, 2024

Scenario:

  1. Log in
  2. Go to any records tab (e.g. People tab)
  3. Delete any records
  4. Go to Options > Deleted records
  5. Delete soft-deleted record again

Actual: Popup message informs that it's possible to recover them
Image

Expected: Popup message must clearly inform that deleting soft-deleted records makes them impossible to recover

@Bonapara
Copy link
Member

Great point!

We should display:

Erase 1 record

Are you sure to permanently erase this record? You won't be able to recover it.

@BKM14
Copy link
Contributor

BKM14 commented Nov 23, 2024

There is a bigger problem here I think. I tried re-creating the issue and found that once an entry is soft-deleted and if we delete it again from the options, it doesn't delete it at all.

@BOHEUS
Copy link
Contributor Author

BOHEUS commented Nov 23, 2024

@BKM14 that's outside of the scope of this issue as problem with deleting permamently records is tracked in #7066

@omarNaifer12
Copy link
Contributor

@BOHEUS @Bonapara Hi, it seems easy. Can I work on it?

@omarNaifer12
Copy link
Contributor

I noticed that when a record is deleted, the total record count doesn’t update. Should this be fixed?
https://github.com/user-attachments/assets/91a418b6-3aa2-4a85-a3ec-4de128ab0f32

@BOHEUS
Copy link
Contributor Author

BOHEUS commented Dec 1, 2024

@omarNaifer12 since no one is assigned to this issue, feel free to fix this

@twentyhq twentyhq deleted a comment from oss-gg bot Dec 2, 2024
@twentyhq twentyhq deleted a comment from omarNaifer12 Dec 2, 2024
@Bonapara
Copy link
Member

Bonapara commented Dec 2, 2024

I noticed that when a record is deleted, the total record count doesn’t update. Should this be fixed? https://github.com/user-attachments/assets/91a418b6-3aa2-4a85-a3ec-4de128ab0f32

@lucasbordeau can this be achieved with optimistic rendering?

@muraliSingh7
Copy link
Contributor

@Bonapara @BOHEUS : I have a solution to fix the count after deleting records. It will also fix #8228 issue. Nothing complex just need to add one or two line. In this if you want message to be updated I will find out and fix that too. May I implement it ?

@Bonapara
Copy link
Member

Bonapara commented Dec 3, 2024

@khuddite seems to be on it, @muraliSingh7! @khuddite, do you think you can fix this one as well, as suggested by @muraliSingh7? Thanks to you both 🙏

@muraliSingh7
Copy link
Contributor

@Bonapara I reviewed a PR recently closed by @khuddite , which was going to implement the same approach I had in mind. However, the PR discussion indicates that the internal team prefers a different solution and plans to implement it themselves.

@khuddite
Copy link
Contributor

khuddite commented Dec 3, 2024

#8366 (comment)

@Bonapara @muraliSingh7 I am not actively working on the issue, it seems we are not clear on how to fix it yet. Please feel free to refer to the above link.

@omarNaifer12
Copy link
Contributor

I don’t know why I said easy. I won’t use that word anymore in this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🆕 New
Development

Successfully merging a pull request may close this issue.

6 participants