Skip to content

Commit

Permalink
fix(#753): add autoComplete attribute for remove suggestion of passwo… (
Browse files Browse the repository at this point in the history
#913)

* fix(#753): add autoComplete attribute for remove suggestion of password managers

* fix(#753): add autoComplete attribute for remove suggestion of password managers

* Update front/src/modules/ui/inplace-input/components/InplaceInputDoubleText.tsx

* Update front/src/modules/ui/inplace-input/components/InplaceInputDoubleText.tsx

* Update front/src/modules/ui/inplace-input/components/InplaceInputDoubleText.tsx

* Update front/src/modules/ui/inplace-input/components/InplaceInputDoubleText.tsx

---------

Co-authored-by: Charles Bochet <[email protected]>
  • Loading branch information
gfr2003 and charlesBochet authored Jul 25, 2023
1 parent a5ca913 commit 59eb10c
Show file tree
Hide file tree
Showing 13 changed files with 14 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,7 @@ export function CommentThread({
<CommentThreadActionBar commentThreadId={commentThread?.id ?? ''} />
</StyledTopActionsContainer>
<StyledEditableTitleInput
autoComplete="off"
autoFocus
placeholder={`${commentThread.type} title (optional)`}
onChange={(event) => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ export function BoardCardEditableFieldText({
placeholder={placeholder || ''}
autoFocus
value={internalValue}
autoComplete="off"
onChange={(event: ChangeEvent<HTMLInputElement>) => {
setInternalValue(event.target.value);
debouncedOnChange(event.target.value);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ export function BoardColumnEditTitleMenu({
<StyledEditModeInput
value={internalValue}
onChange={handleChange}
autoComplete="off"
autoFocus
/>
</StyledEditTitleContainer>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ export function DropdownMenuSearch(
return (
<DropdownMenuSearchContainer>
<StyledEditModeSearchInput
autoComplete="off"
{...props}
placeholder={props.placeholder ?? 'Search'}
/>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ export function InplaceInputDoubleText({
}}
/>
<StyledInput
autoComplete="off"
placeholder={secondValuePlaceholder}
value={secondValue}
onChange={(event: ChangeEvent<HTMLInputElement>) => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ export function InplaceInputText({
return (
<InplaceInputContainer>
<InplaceInputTextInput
autoComplete="off"
autoFocus={autoFocus}
placeholder={placeholder}
value={value}
Expand Down
1 change: 1 addition & 0 deletions front/src/modules/ui/input/components/Checkbox.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ export function Checkbox({
return (
<StyledInputContainer>
<StyledInput
autoComplete="off"
type="checkbox"
name="styled-checkbox"
data-testid="input-checkbox"
Expand Down
1 change: 1 addition & 0 deletions front/src/modules/ui/input/components/TextInput.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,7 @@ export function TextInput({
{label && <StyledLabel>{label + (required ? '*' : '')}</StyledLabel>}
<StyledInputContainer>
<StyledInput
autoComplete="off"
ref={inputRef}
tabIndex={props.tabIndex ?? 0}
onFocus={handleFocus}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,7 @@ export function EditableCellDoubleTextEditMode({
return (
<StyledContainer ref={wrapperRef}>
<StyledInput
autoComplete="off"
autoFocus
placeholder={firstValuePlaceholder}
ref={firstValueInputRef}
Expand All @@ -147,6 +148,7 @@ export function EditableCellDoubleTextEditMode({
}}
/>
<StyledInput
autoComplete="off"
placeholder={secondValuePlaceholder}
ref={secondValueInputRef}
value={secondValue}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ export function EditableCellPhone({ value, placeholder, onSubmit }: OwnProps) {
<EditableCell
editModeContent={
<InplaceInputTextEditMode
autoComplete="off"
autoFocus
placeholder={placeholder || ''}
value={value}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ export function EditableCellText({
autoFocus
value={value}
onSubmit={(newText) => onSubmit?.(newText)}
autoComplete="off"
/>
}
nonEditModeContent={
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ export function EditableCellURL({
editModeContent={
<InplaceInputTextEditMode
placeholder={placeholder}
autoComplete="off"
autoFocus
value={url}
onSubmit={(newURL) => onSubmit?.(newURL)}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ export function EditableCellChip({
placeholder={placeholder || ''}
autoFocus
value={inputValue}
autoComplete="off"
onSubmit={(newValue) => onSubmit?.(newValue)}
/>
}
Expand Down

0 comments on commit 59eb10c

Please sign in to comment.