refactor: extract parser formats in constants

twentyhq · Dec 11, 2024 · 1ce4d95 · 1ce4d95
1 parent e00e692
commit 1ce4d95
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 2 deletions.
diff --git a/.../twenty-front/src/modules/ui/input/components/internal/date/constants/DateParserFormat.ts b/.../twenty-front/src/modules/ui/input/components/internal/date/constants/DateParserFormat.ts
@@ -0,0 +1 @@
+export const DATE_PARSER_FORMAT = 'MM/dd/yyyy';
diff --git a/...nty-front/src/modules/ui/input/components/internal/date/constants/DateTimeParserFormat.ts b/...nty-front/src/modules/ui/input/components/internal/date/constants/DateTimeParserFormat.ts
@@ -0,0 +1 @@
+export const DATE_TIME_PARSER_FORMAT = 'MM/dd/yyyy HH:mm';
diff --git a/...ges/twenty-front/src/modules/ui/input/components/internal/date/utils/parseDateToString.ts b/...ges/twenty-front/src/modules/ui/input/components/internal/date/utils/parseDateToString.ts
@@ -1,3 +1,5 @@
+import { DATE_PARSER_FORMAT } from '@/ui/input/components/internal/date/constants/DateParserFormat';
+import { DATE_TIME_PARSER_FORMAT } from '@/ui/input/components/internal/date/constants/DateTimeParserFormat';
 import { DateTime } from 'luxon';
 
 type ParseDateToStringArgs = {
@@ -11,7 +13,9 @@ export const parseDateToString = ({
   isDateTimeInput,
   userTimezone,
 }: ParseDateToStringArgs) => {
-  const parsingFormat = isDateTimeInput ? 'MM/dd/yyyy HH:mm' : 'MM/dd/yyyy';
+  const parsingFormat = isDateTimeInput
+    ? DATE_TIME_PARSER_FORMAT
+    : DATE_PARSER_FORMAT;
 
   const dateParsed = DateTime.fromJSDate(date, { zone: userTimezone });
 

diff --git a/...ges/twenty-front/src/modules/ui/input/components/internal/date/utils/parseStringToDate.ts b/...ges/twenty-front/src/modules/ui/input/components/internal/date/utils/parseStringToDate.ts
@@ -1,3 +1,5 @@
+import { DATE_PARSER_FORMAT } from '@/ui/input/components/internal/date/constants/DateParserFormat';
+import { DATE_TIME_PARSER_FORMAT } from '@/ui/input/components/internal/date/constants/DateTimeParserFormat';
 import { DateTime } from 'luxon';
 
 type ParseStringToDateArgs = {
@@ -11,7 +13,9 @@ export const parseStringToDate = ({
   isDateTimeInput,
   userTimezone,
 }: ParseStringToDateArgs) => {
-  const parsingFormat = isDateTimeInput ? 'MM/dd/yyyy HH:mm' : 'MM/dd/yyyy';
+  const parsingFormat = isDateTimeInput
+    ? DATE_TIME_PARSER_FORMAT
+    : DATE_PARSER_FORMAT;
 
   const parsedDate = isDateTimeInput
     ? DateTime.fromFormat(dateAsString, parsingFormat, { zone: userTimezone })
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		export const DATE_PARSER_FORMAT = 'MM/dd/yyyy';
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		export const DATE_TIME_PARSER_FORMAT = 'MM/dd/yyyy HH:mm';