Add support for getting a Signed URL in GCS Adapter #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… adapters, + add option parameter to fetch public or signed url for azure and gcs adapters
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I modified the 'getFileAsURL' function for the GCS and Azure Adapters to add the possibility of getting both a public URL and a signed URL for files in private buckets. We use this funcionality for files in Azure and GCS, but the GCS Adapter only returned public URLs, making it impossible to download files from private buckets even though we were authenticated. With the changed I am proposing we can still get the public URL as before and the signed URL if we need it. I also updated the use of the options parameter so it is actually used in those two adapters.