simplify client program api #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
folkertdev
commented
Aug 27, 2024
| target_type: Option<TargetLabel>, | ||
| targets: &[&str], | ||
| filter: Filter<'_>, |
There was a problem hiding this comment.
now consistent with the equivalent api for events
Comment on lines
-414
to
-432
| /// Get a single program from the VTN that matches the given target | ||
| pub async fn get_program(&self, target: Target<'_>) -> Result<ProgramClient> { | ||
| let pagination = PaginationOptions { skip: 0, limit: 2 }; | ||
|
|
||
| let mut programs = self | ||
| .get_programs_request( | ||
| Some(target.target_label()), | ||
| target.target_values(), | ||
| pagination, | ||
| ) | ||
| .await?; | ||
|
|
||
| match programs[..] { | ||
| [] => Err(crate::Error::ObjectNotFound), | ||
| [_] => Ok(programs.remove(0)), | ||
| [..] => Err(crate::Error::DuplicateObject), | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
the only target that you can give that gives a single result is ProgramName, so we can just use a get_program_by_name
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #93 +/- ##
==========================================
- Coverage 72.88% 72.86% -0.03%
==========================================
Files 28 28
Lines 3552 3541 -11
==========================================
- Hits 2589 2580 -9
+ Misses 963 961 -2 ☔ View full report in Codecov by Sentry. |
rnijveld
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.