Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release 0.4.0 #75

Merged
merged 2 commits into from
Dec 22, 2023
Merged

Prepare release 0.4.0 #75

merged 2 commits into from
Dec 22, 2023

Conversation

avdv
Copy link
Member

@avdv avdv commented Dec 22, 2023

A new release is in order since version 0.3.0 that is currently published to the BCR is not compatible with Bazel 7, as it is failing on amd64 Darwin with:

(07:18:17) INFO: ToolchainResolution: Performing resolution of @@rules_sh~0.3.0//sh/posix:toolchain_type for target platform @@local_config_platform//:host
      ToolchainResolution:   Toolchain @@rules_sh~0.3.0~sh_configure~local_posix_config//:local_posix is compatible with target plaform, searching for execution platforms:
      ToolchainResolution:     Incompatible execution platform @@local_config_platform//:host; mismatching values: linux
      ToolchainResolution: No @@rules_sh~0.3.0//sh/posix:toolchain_type toolchain found for target platform @@local_config_platform//:host.
(07:18:17) INFO: ToolchainResolution: Performing resolution of @@rules_sh~0.3.0//sh/posix:toolchain_type for target platform @@local_config_platform//:host
      ToolchainResolution:   Toolchain @@rules_sh~0.3.0~sh_configure~local_posix_config//:local_posix is compatible with target plaform, searching for execution platforms:
      ToolchainResolution:     Incompatible execution platform @@local_config_platform//:host; mismatching values: linux
      ToolchainResolution: No @@rules_sh~0.3.0//sh/posix:toolchain_type toolchain found for target platform @@local_config_platform//:host.

This is caused by an unexpected os value, which is gets mapped to linux.

@avdv avdv requested a review from aherrmann December 22, 2023 09:25
Copy link
Member

@aherrmann aherrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@avdv avdv marked this pull request as ready for review December 22, 2023 10:00
@avdv avdv added the merge-queue merge on green CI label Dec 22, 2023
@mergify mergify bot merged commit 63f58a0 into master Dec 22, 2023
20 checks passed
@mergify mergify bot deleted the release-0.4.0 branch December 22, 2023 10:01
@mergify mergify bot removed the merge-queue merge on green CI label Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants