vendor large parts of @bazel_tools//tools/cpp #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malt3
force-pushed
the
mp/cc_toolchain_vendoring
branch
4 times, most recently
from
c3d4c63 to
44b2669
Compare
…e//private/cc_toolchain Most of @bazel_tools//tools/cpp was removed from @bazel_tools and moved into a private package in rules_cc in Bazel 8.
This is only available in Bazel 8 and later. See bazelbuild/bazel#9e913fbfa2e3930742fc30dfb60ac5e2694c70cf
This is only available in Bazel 7 and later. See bazelbuild/bazel#b272cef7d4b2d1be4e3f82b737c3c14d5e768aea
…les_cc Bazel 7 and prior requires a matching unix_cc_toolchain_config (with the appropriate features for that Bazel version). That one is bound to the Bazel version and can be loaded from @bazel_tools up to Bazel 8, where it was moved to rules_cc.
malt3
force-pushed
the
mp/cc_toolchain_vendoring
branch
from
8464597 to
07e23e1
Compare
|
@malt3 Regards, |
|
Thx, got it. Sorry but I'm a core x86_64-linux user. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of @bazel_tools//tools/cpp was removed from @bazel_tools and moved into a private package in rules_cc in Bazel 8.
It looks like some parameters of
cc_toolchain_configwhere added over the years and are not available in all versions of Bazel.I ended up doing some clever version checks when selecting the right version of
unix_cc_toolchain_config.bzl.Fixes #612