Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove nixpkgs_cc_configure_deprecated #621

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

malt3
Copy link
Collaborator

@malt3 malt3 commented Nov 29, 2024

nixpkgs_cc_configure_deprecated depended on Bazel's cc_autoconf_impl, which was removed from @bazel_tools and moved into a private package in rules_cc in Bazel 8.

See also: bazelbuild/bazel#23809

`nixpkgs_cc_configure_deprecated` depended on Bazel's
cc_autoconf_impl, which was removed from @bazel_tools
and moved into a private package in rules_cc in Bazel 8.

See also: bazelbuild/bazel#23809
@malt3 malt3 marked this pull request as ready for review November 29, 2024 21:12
@malt3 malt3 requested a review from a team as a code owner November 29, 2024 21:12
@malt3 malt3 requested a review from avdv November 29, 2024 21:13
Copy link
Member

@avdv avdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@malt3 malt3 added the merge-queue merge on green CI label Dec 2, 2024
@mergify mergify bot merged commit ad1e338 into master Dec 2, 2024
13 checks passed
@mergify mergify bot deleted the mp/remove_nixpkgs_cc_configure_deprecated branch December 2, 2024 09:37
@mergify mergify bot removed the merge-queue merge on green CI label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants