nixpkgs_flake_package() supplies --experimental-features 'nix-command flakes' in case someone's local nix.conf hasn't enabled them.
#465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layus
requested changes
Dec 11, 2023
core/nixpkgs.bzl
Outdated
| @@ -790,7 +790,7 @@ def _nixpkgs_flake_package_impl(repository_ctx): | |||
| extra_msg = "See: https://nixos.org/nix/", | |||
| ) | |||
|
|
|||
| _nixpkgs_build_and_symlink(repository_ctx, [nix_path, "build"], expr_args, build_file_content) | |||
| _nixpkgs_build_and_symlink(repository_ctx, [nix_path, "--experimental-features", "nix-command flakes", "build"], expr_args, build_file_content) | |||
There was a problem hiding this comment.
Suggested change
| _nixpkgs_build_and_symlink(repository_ctx, [nix_path, "--experimental-features", "nix-command flakes", "build"], expr_args, build_file_content) | |
| _nixpkgs_build_and_symlink(repository_ctx, [nix_path, "--extra-experimental-features", "nix-command flakes", "build"], expr_args, build_file_content) |
There was a problem hiding this comment.
Good idea! Done 🙂
…and flakes'` in case someone's local `nix.conf` hasn't enabled them.
rickvanprim
force-pushed
the
flake_experimental_features
branch
from
3962b20 to
7a832ba
Compare
|
One more thought I have while I'm in here, def is_supported_platform(repository_ctx):
return repository_ctx.which("nix-build") != NoneShould this switch to checking |
|
The existence of |
benradf
approved these changes
Dec 13, 2023
layus
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@layus does this seem reasonable? I'm not aware of any downsides for unconditionally passing these flags.