Use non-prebuild Java toolchain configuration #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On NixOS we cannot use the pre-built `ijar` and `singlejar` tools as they are not statically build and fail to find the dynamic linker. Fixes #278
We were still on version 4.0.0 but already got version 5.5.1 in the resolved dependency graph. We need to use at least version 6.1.0 since former versions of rules_java failed to declare a dependency on rules_license which is now referenced.
This fixes CI errors for toolchains/java: ``` external/bazel_tools/tools/osx/xcode_configure.bzl:93:14: Invoking xcodebuild failed, developer dir: /Applications/Xcode_12.4.app/Contents/Developer ,return code 1, stderr: src/main/tools/process-wrapper-legacy.cc:80: "execvp(xcrun, ...)": No such file or directory ```
Bazel requires `libtool` for creating static archives on Darwin instead of the `ar` tool.
avdv
force-pushed
the
use-nonprebuilt-java-tools
branch
from
ba9452b to
de6e2b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On NixOS we cannot use the pre-built
ijarandsinglejartools as they are not statically build and fail to find the dynamic linker.Fixes #278