Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clang resource share directory to search path #437

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

avdv
Copy link
Member

@avdv avdv commented Oct 25, 2023

This is needed e.g. when using -fsanitize=address which would otherwise fail with:

this rule is missing dependency declarations for the following files included by ...
 '/nix/store/9k6s3zmhj2pvkg8a5s8n7d2sbpffv8hv-clang-wrapper-16.0.1/resource-root/share/asan_ignorelist.txt'

Fixes #430

See bazelbuild/bazel@f32b0fd and bazelbuild/bazel#10510 for similar work.

This is needed e.g. when using `-fsanitize=address` which would otherwise fail with:
```
this rule is missing dependency declarations for the following files included by ...
 '/nix/store/9k6s3zmhj2pvkg8a5s8n7d2sbpffv8hv-clang-wrapper-16.0.1/resource-root/share/asan_ignorelist.txt'
```

Fixes #430
Copy link
Member

@aherrmann aherrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you!

@avdv avdv added the merge-queue merge on green CI label Oct 27, 2023
@mergify mergify bot merged commit 3e21df2 into master Oct 27, 2023
15 checks passed
@mergify mergify bot deleted the fix-add-resource-share-dir branch October 27, 2023 15:41
@mergify mergify bot removed the merge-queue merge on green CI label Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

asan doesn't work with nixpkgs cc toolchain
2 participants