Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add reference to examples in README #217

Merged
merged 1 commit into from
Apr 12, 2022
Merged

add reference to examples in README #217

merged 1 commit into from
Apr 12, 2022

Conversation

fricklerhandwerk
Copy link
Member

help newcomers orient themselves how to actually use rules_nixpkgs

Copy link
Contributor

@steshaw steshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

A nice follow-up might be to move the multiline strings containing strings to external .md files to make them easier to edit (with editor supported modes). If possible of course.

@steshaw steshaw merged commit a0a399f into master Apr 12, 2022
@steshaw steshaw deleted the readme-examples branch April 12, 2022 22:02
@fricklerhandwerk
Copy link
Member Author

It is possible and we had this until recently, but this made documentation rendering fairly complex as it required more build steps, and made the source harder to navigate. It's of course a trade-off. Right now it is not that much text and everything is self-contained in between the actual code, so it seems appropriate to me.

@steshaw
Copy link
Contributor

steshaw commented Apr 14, 2022

@fricklerhandwerk I'd like to take a look at the previous complexity. Can you point me at a commit?

@fricklerhandwerk
Copy link
Member Author

@steshaw #202 and this specifically.

@steshaw
Copy link
Contributor

steshaw commented Apr 19, 2022

Thanks. I see! That does indeed look complicated. What's more, it doesn't help with editor tooling to have the markdown file in a template file .md.tpl. The complexity seems to be related to processing the .tpl file using AWK. I was thinking more of a README.top.md and README.bottom.md and then just concatenating those with the generated API docs with cat. That might be awkward though. It is a trade-off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants