Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: configure OS-specific variables in .bazelrc #2102

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

cgrindel
Copy link
Contributor

@cgrindel cgrindel commented Jan 5, 2024

  • Add --enable_platform_specific_config to .bazelrc.common.
  • Move MacOS- and Windows-specific environment variables to .bazelrc.common under their OS config names.
  • Update code that generates bazelrc files for integration tests to include the new entries.

Related to #2099.

@cgrindel cgrindel self-assigned this Jan 5, 2024
@cgrindel cgrindel marked this pull request as ready for review January 5, 2024 22:16
@cgrindel cgrindel requested a review from avdv as a code owner January 5, 2024 22:16
Copy link
Member

@avdv avdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you.

Should we also remove the BAZEL_USE_CPP_ONLY_TOOLCHAIN variable from the shell.nix file?

@cgrindel cgrindel added merge-queue merge on green CI and removed merge-queue merge on green CI labels Jan 8, 2024
@cgrindel
Copy link
Contributor Author

cgrindel commented Jan 8, 2024

@Mergifyio squash title+body

- Add `--enable_platform_specific_config` to `.bazelrc.common`.
- Move MacOS- and Windows-specific environment variables to `.bazelrc.common` under their OS config names.
- Update code that generates bazelrc files for integration tests to include the new entries.

Related to #2099.
Copy link
Contributor

mergify bot commented Jan 8, 2024

squash title+body

✅ Pull request squashed successfully

@cgrindel cgrindel added the merge-queue merge on green CI label Jan 8, 2024
@mergify mergify bot merged commit d18915c into master Jan 8, 2024
51 checks passed
@mergify mergify bot deleted the gh2099_env_specific_config branch January 8, 2024 19:54
@mergify mergify bot removed the merge-queue merge on green CI label Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants