Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker #27

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Docker #27

merged 1 commit into from
Mar 18, 2024

Conversation

tauqirsarwar1
Copy link
Collaborator

To be filled by the PR creator:

  • A brief description of the changes made -

  • Do we have clean latest run report attached with this PR?

    • Yes
    • No (Please explain why)
  • Does the PR contain changes to any BP core file?

    • Yes (Needs approval from at least 2 people)
    • No
  • Does the PR contain changes to modules shared with other teams?

    • Yes (Needs approval from at least one of the other teams that use the module)
    • No
  • Is it

    • New Testcase
    • Fix

To be filled by the PR reviewer:

  • Verify the attached run report passed in GitHub Actions (Justify if local run)

  • General

    • Use the best strategy to locate the elements
    • Comments wherever the code is not readable by itself
    • Use of the right data structure for the use case
    • Reuse logic/functionality as much as possible
    • Cleanup of any test data that is generated by the tests
    • No static waits

@tauqirsarwar1 tauqirsarwar1 merged commit 765d027 into master Mar 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant