Skip to content

Commit

Permalink
Develop (#148)
Browse files Browse the repository at this point in the history
### To be filled by the PR creator:

* A brief description of the changes made - 

* Do we have clean latest run report (Docker or Browserstack) attached
with this PR?
  * [ ] Yes
  * [ ] No (Please explain why)

* Does the PR contain changes to any core file?
  * [ ] Yes (Needs approval from at least 1 people)
  * [ ] No

* Is it
  * [ ] New Testcase
  * [ ] Fix


### To be filled by the PR reviewer:

* [ ] Verify the attached run report passed in GitHub Actions (Docker or
Browserstack run)

* General
    * [ ] Use the best strategy to locate the elements
    * [ ] Comments wherever the code is not readable by itself
    * [ ] Use of the right data structure for the use case
    * [ ] Reuse logic/functionality as much as possible
    * [ ] Cleanup of any test data that is generated by the tests
    * [ ] No static waits
  • Loading branch information
tauqirsarwar1 authored Aug 15, 2024
2 parents 0339c8d + d3493ec commit ebdeb50
Showing 1 changed file with 8 additions and 9 deletions.
17 changes: 8 additions & 9 deletions .github/workflows/LT_ui_workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ jobs:

- name: Check out code
id: co_code
if: steps.bs_local_tunnel_setup.outcome == 'success'
if: steps.tunnel.outcome == 'success'
uses: actions/checkout@v4

- name: Setup dependencies
Expand All @@ -236,27 +236,26 @@ jobs:
BASE_URL="${{ github.event.inputs.baseurl }}"
fi
if [[ "${{ github.event.inputs.browser }}" == "chrome" && "${{ github.event.inputs.os }}" == "window" ]]; then
BROWSER=./env_configs/win_chrome.json
BROWSER=./env_configs/lamdatest/win_chrome_LT.json
fi
if [[ "${{ github.event.inputs.browser }}" == "firefox" && "${{ github.event.inputs.os }}" == "window" ]]; then
BROWSER=./env_configs/win_firefox.json
BROWSER=./env_configs/lamdatest/win_firefox_LT.json
fi
if [[ "${{ github.event.inputs.browser }}" == "edge" && "${{ github.event.inputs.os }}" == "window" ]]; then
BROWSER=./env_configs/win_edge.json
BROWSER=./env_configs/lamdatest/win_edge_LT.json
fi
if [[ "${{ github.event.inputs.browser }}" == "chrome" && "${{ github.event.inputs.os }}" == "mac" ]]; then
BROWSER=./env_configs/mac_chrome.json
BROWSER=./env_configs/lamdatest/mac_chrome_LT.json
fi
if [[ "${{ github.event.inputs.browser }}" == "firefox" && "${{ github.event.inputs.os }}" == "mac" ]]; then
BROWSER=./env_configs/mac_firefox.json
BROWSER=./env_configs/lamdatest/mac_firefox_LT.json
fi
if [[ "${{ github.event.inputs.browser }}" == "safari" && "${{ github.event.inputs.os }}" == "mac" ]]; then
BROWSER=./env_configs/mac_safari.json
BROWSER=./env_configs/lamdatest/mac_safari_LT.json
fi
if [[ "${{ github.event.inputs.browser }}" == "edge" && "${{ github.event.inputs.os }}" == "mac" ]]; then
BROWSER=./env_configs/mac_edge.json
BROWSER=./env_configs/lamdatest/mac_edge_LT.json
fi
env
Expand Down

0 comments on commit ebdeb50

Please sign in to comment.