Skip to content

Commit

Permalink
Develop (#26)
Browse files Browse the repository at this point in the history
### To be filled by the PR creator:

* A brief description of the changes made - 

* Do we have clean latest run report attached with this PR?
  * [ ] Yes
  * [ ] No (Please explain why)

* Does the PR contain changes to any BP core file?
  * [ ] Yes (Needs approval from at least 2 people)
  * [ ] No

* Does the PR contain changes to modules shared with other teams?
* [ ] Yes (Needs approval from at least one of the other teams that use
the module)
  * [ ] No

* Is it
  * [ ] New Testcase
  * [ ] Fix


### To be filled by the PR reviewer:

* [ ] Verify the attached run report passed in GitHub Actions (Justify
if local run)

* General
    * [ ] Use the best strategy to locate the elements
    * [ ] Comments wherever the code is not readable by itself
    * [ ] Use of the right data structure for the use case
    * [ ] Reuse logic/functionality as much as possible
    * [ ] Cleanup of any test data that is generated by the tests
    * [ ] No static waits
  • Loading branch information
Tauqir Sarwar authored Mar 18, 2024
2 parents ed7eac9 + 403d2dd commit ac3ba96
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 7 deletions.
File renamed without changes.
8 changes: 1 addition & 7 deletions .github/workflows/docker_workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -153,15 +153,9 @@ jobs:
with:
python-version: "3.9"

- name: Setup Docker Practice
id: setup_docker_practice
if: steps.setup_python.outcome == 'success'
uses: docker-practice/actions-setup-docker@master
timeout-minutes: 12

- name: Set up Docker
id: docker_env_setup
if: steps.setup_docker_practice.outcome == 'success'
if: steps.setup_python.outcome == 'success'
uses: docker/setup-buildx-action@v3

- name: Build and start Docker Compose services
Expand Down

0 comments on commit ac3ba96

Please sign in to comment.