Skip to content

Commit

Permalink
Develop (#49)
Browse files Browse the repository at this point in the history
### To be filled by the PR creator:

* A brief description of the changes made - 

* Do we have clean latest run report attached with this PR?
  * [ ] Yes
  * [ ] No (Please explain why)

* Does the PR contain changes to any BP core file?
  * [ ] Yes (Needs approval from at least 2 people)
  * [ ] No

* Does the PR contain changes to modules shared with other teams?
* [ ] Yes (Needs approval from at least one of the other teams that use
the module)
  * [ ] No

* Is it
  * [ ] New Testcase
  * [ ] Fix


### To be filled by the PR reviewer:

* [ ] Verify the attached run report passed in GitHub Actions (Justify
if local run)

* General
    * [ ] Use the best strategy to locate the elements
    * [ ] Comments wherever the code is not readable by itself
    * [ ] Use of the right data structure for the use case
    * [ ] Reuse logic/functionality as much as possible
    * [ ] Cleanup of any test data that is generated by the tests
    * [ ] No static waits
  • Loading branch information
Tauqir Sarwar authored Mar 21, 2024
2 parents 4f9725f + e524230 commit 9413078
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 21 deletions.
14 changes: 6 additions & 8 deletions .github/workflows/docker_android_workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,17 +45,16 @@ jobs:
if: steps.setup_java.outcome == 'success'
run: |
npm install -g appium
appium --log-level debug &
sleep 10
appium -v
- name: Install drivers
id: install_drivers
if: steps.setup_appium.outcome == 'success'
run: |
appium driver install xcuitest
appium driver install uiautomator2
sleep 5
appium --log-level debug &
sleep 10
appium -v
- name: Run Emulator
id: run_emulator
Expand Down Expand Up @@ -123,17 +122,16 @@ jobs:
if: steps.setup_python.outcome == 'success'
run: |
npm install -g appium
appium --log-level debug &
sleep 5
appium -v
- name: Install drivers
id: install_drivers
if: steps.setup_appium.outcome == 'success'
run: |
appium driver install xcuitest
appium driver install uiautomator2
sleep 5
appium --log-level debug &
sleep 10
appium -v
- name: Run Android Emulator
id: run_emulator
Expand Down
14 changes: 6 additions & 8 deletions .github/workflows/docker_ios_workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,17 +37,16 @@ jobs:
if: steps.co_code.outcome == 'success'
run: |
npm install -g appium
appium --log-level debug &
sleep 5
appium -v
- name: Install drivers
id: install_drivers
if: steps.setup_appium.outcome == 'success'
run: |
appium driver install xcuitest
appium driver install uiautomator2
sleep 5
appium --log-level debug &
sleep 10
appium -v
- name: Set up X Code
id: setup_xcode
Expand Down Expand Up @@ -123,17 +122,16 @@ jobs:
if: steps.co_code.outcome == 'success'
run: |
npm install -g appium
appium --log-level debug &
sleep 5
appium -v
- name: Install drivers
id: install_drivers
if: steps.setup_appium.outcome == 'success'
run: |
appium driver install xcuitest
appium driver install uiautomator2
sleep 5
appium --log-level debug &
sleep 10
appium -v
- name: Set up X Code
Expand Down
4 changes: 2 additions & 2 deletions configs/android_mobile_docker.json
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{
"capabilities": {
"deviceName": "emulator-5554",
"platformName": "android",
"app": "/home/runner/work/pytest-automation-boilerplate/pytest-automation-boilerplate/app files/builds/Android-MyDemoAppRN.1.3.0.build-244.apk",
"platformName": "Android",
"app": "/Users/runner/work/pytest-automation-boilerplate/pytest-automation-boilerplate/app files/builds/Android-MyDemoAppRN.1.3.0.build-244.apk",
"noReset": false,
"newCommandTimeout": 3600
}
Expand Down
6 changes: 3 additions & 3 deletions configs/ios_mobile_docker.json
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
{
"capabilities": {
"platformVersion": "17.0",
"platformVersion": "16.2",
"deviceName": "iPhone 14 Pro",
"platformName": "ios",
"app": "/home/runner/work/pytest-automation-boilerplate/pytest-automation-boilerplate/app files/builds/MyRNDemoApp.app",
"platformName": "iOS",
"app": "/Users/runner/work/pytest-automation-boilerplate/pytest-automation-boilerplate/app files/builds/MyRNDemoApp.app",
"noReset": false,
"newCommandTimeout": 3600
}
Expand Down

0 comments on commit 9413078

Please sign in to comment.