Skip to content

Commit

Permalink
Docker Web Fixes (#42)
Browse files Browse the repository at this point in the history
### To be filled by the PR creator:

* A brief description of the changes made - 

* Do we have clean latest run report attached with this PR?
  * [ ] Yes
  * [ ] No (Please explain why)

* Does the PR contain changes to any BP core file?
  * [ ] Yes (Needs approval from at least 2 people)
  * [ ] No

* Does the PR contain changes to modules shared with other teams?
* [ ] Yes (Needs approval from at least one of the other teams that use
the module)
  * [ ] No

* Is it
  * [ ] New Testcase
  * [ ] Fix


### To be filled by the PR reviewer:

* [ ] Verify the attached run report passed in GitHub Actions (Justify
if local run)

* General
    * [ ] Use the best strategy to locate the elements
    * [ ] Comments wherever the code is not readable by itself
    * [ ] Use of the right data structure for the use case
    * [ ] Reuse logic/functionality as much as possible
    * [ ] Cleanup of any test data that is generated by the tests
    * [ ] No static waits
  • Loading branch information
Tauqir Sarwar authored Mar 20, 2024
2 parents 53a427a + aac7b9f commit 6d8fc56
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 4 deletions.
7 changes: 5 additions & 2 deletions .github/workflows/docker_ui_workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Setup Python
id: setup_python
uses: actions/setup-python@v5
with:
python-version: "3.9"
Expand All @@ -100,10 +101,12 @@ jobs:
run: sleep 30

- name: Setup dependencies
id: setup_dependencies
run: |
sh install.sh
- name: Run All Tests
if: steps.setup_dependencies.outcome == 'success'
run: |
env
source $HOME/.bp-venv/bin/activate
Expand Down Expand Up @@ -197,7 +200,7 @@ jobs:
BASE_URL="${{ github.event.inputs.baseurl }}"
fi
number_of_threads=1
concurrent_thread=3
if [[ "${{ github.event.inputs.browser }}" == "chrome" ]]; then
BROWSER=./configs/docker_chrome.json
Expand All @@ -217,7 +220,7 @@ jobs:
--variables "$BROWSER" \
--reruns 1 --reruns-delay 5 \
--tags="$TAGS" --base-url="$BASE_URL" --html=report.html \
--self-contained-html -n 3
--self-contained-html -n "${{ concurrent_thread }}"
- name: Docker Container Stop
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ui_workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ jobs:
BASE_URL="${{ github.event.inputs.baseurl }}"
fi
number_of_threads=1
concurrent_thread=2
if [[ "${{ github.event.inputs.browser }}" == "chrome" && "${{ github.event.inputs.os }}" == "window" ]]; then
BROWSER=./configs/win_chrome.json
Expand Down Expand Up @@ -308,7 +308,7 @@ jobs:
--capability headless False \
--reruns 1 --reruns-delay 5 \
--tags="$TAGS" --base-url="$BASE_URL" --html=report.html \
--self-contained-html -n 2
--self-contained-html -n ${{ concurrent_thread }}
- name: BrowserStackLocal Stop
uses: browserstack/github-actions/setup-local@master
Expand Down

0 comments on commit 6d8fc56

Please sign in to comment.