Multiline support in the REPL #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 All dependencies have been resolved ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depend on #261. Partly address #257. Add multiline support, that is if the user hit ENTER on an incomplete input, the editor go to the next line and stays in input mode.
To determine if the line should end, the REPL tries to parse the input and don't end the input if parsing results in
Unexpected end of fileerror.Auto-indentation is not supported because it doesn't seem trivial to implement in rustyline (that is, without losing all the interesting features). Some related PRs have recent activity (kkawakam/rustyline#466), so let's wait and see on this side for now.