Freeze records on insert/remove/update. #2131
Conversation
|
Bencher Report| Branch | freeze-em |
| Testbed | ubuntu-latest |
Click to view all benchmark results
| Benchmark | Latency | nanoseconds (ns) |
|---|---|---|
| fibonacci 10 | 📈 view plot 🚷 view threshold | 498.18 |
| foldl arrays 50 | 📈 view plot 🚷 view threshold | 1,752.40 |
| foldl arrays 500 | 📈 view plot 🚷 view threshold | 6,786.60 |
| foldr strings 50 | 📈 view plot 🚷 view threshold | 7,083.80 |
| foldr strings 500 | 📈 view plot 🚷 view threshold | 61,846.00 |
| generate normal 250 | 📈 view plot 🚷 view threshold | 46,810.00 |
| generate normal 50 | 📈 view plot 🚷 view threshold | 2,069.60 |
| generate normal unchecked 1000 | 📈 view plot 🚷 view threshold | 3,279.20 |
| generate normal unchecked 200 | 📈 view plot 🚷 view threshold | 756.08 |
| pidigits 100 | 📈 view plot 🚷 view threshold | 3,246.10 |
| pipe normal 20 | 📈 view plot 🚷 view threshold | 1,488.30 |
| pipe normal 200 | 📈 view plot 🚷 view threshold | 9,971.00 |
| product 30 | 📈 view plot 🚷 view threshold | 858.94 |
| scalar 10 | 📈 view plot 🚷 view threshold | 1,548.70 |
| sum 30 | 📈 view plot 🚷 view threshold | 855.76 |
There was a problem hiding this comment.
map doesn't need freezing indeed (or, put differently, it's already been freezing its argument in practice, even if we didn't formulate it that way, because map needs to flush all pending lazy contracts or the result is quite quickly entirely wrong).
I initially delayed this follow-up in order to give a bit of thinking around the idea of having dictionary records freezing their argument (#2113 (comment)). That being said, I think this PR is forward-compatible with this idea, shall we execute, as all those functions have a dictionary type in their signature (we would just revert the manual freezing that you just introduced). It's fine for now, as it fixes the original misbehavior and also unblocks you on the stdlib testing, I suppose.
|
I like the idea of a sharper distinction between records and dictionaries. But yes, I'd like this to go in before we figure that out 😄 |
This finishes off #1877, I think.
I didn't do freezing for
map, because I couldn't find an example where it made a difference. Did I miss something?