Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a GitHub workflow for testing the release infrastructure #1868

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vkleen
Copy link
Contributor

@vkleen vkleen commented Mar 25, 2024

The release-infra-test.yaml workflow can be called manually to build
nixpkgs#hello on the ARM64 runner. The plan is to use it as a test
while making a release to catch problems with the infrastructure early.

TODO: this doesn't work yet, because the infrastructure is only allowed to be run on release tags. I'll look into a good way to address this later.

@github-actions github-actions bot temporarily deployed to pull request March 25, 2024 10:36 Inactive
@github-actions github-actions bot temporarily deployed to pull request March 25, 2024 10:40 Inactive
@vkleen vkleen force-pushed the feat/regular-infra-test branch from eec5f4b to f3b4332 Compare March 25, 2024 10:47
vkleen added 2 commits March 25, 2024 10:48
The `release-infra-test.yaml` workflow can be called manually to build
`nixpkgs#hello` on the ARM64 runner. The plan is to use it as a test
while making a release to catch problems with the infrastructure early.
@vkleen vkleen force-pushed the feat/regular-infra-test branch from f3b4332 to d9374c4 Compare March 25, 2024 10:48
@github-actions github-actions bot temporarily deployed to pull request March 25, 2024 10:51 Inactive
Copy link
Member

@yannham yannham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, beside the thing we must not forget to remove, which is why I'm requesting changes.

@@ -0,0 +1,98 @@
name: Test the ARM64 runner infrastructure
on:
pull_request: # TODO: make absolutely sure to remove this before merging
Copy link
Member

@yannham yannham Mar 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm adding a review comment so that we don't forget to do so. Please resolve only when it's removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants