Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Nickel v1.2.0 #539

Merged
merged 2 commits into from
Sep 14, 2023
Merged

Update to Nickel v1.2.0 #539

merged 2 commits into from
Sep 14, 2023

Conversation

yannham
Copy link
Member

@yannham yannham commented Sep 14, 2023

No description provided.

@yannham yannham requested a review from vkleen September 14, 2023 17:42
@github-actions github-actions bot temporarily deployed to pull request September 14, 2023 17:59 Inactive
@yannham
Copy link
Member Author

yannham commented Sep 14, 2023

@vkleen the type doesn't show in the manual anymore. Any idea why? Could that be related to the changes to nickel doc?

@vkleen
Copy link
Contributor

vkleen commented Sep 14, 2023

Probably, let me take a look

@yannham
Copy link
Member Author

yannham commented Sep 14, 2023

I think it's just a types -> type

@yannham
Copy link
Member Author

yannham commented Sep 14, 2023

I pushed a tentative fix

@github-actions github-actions bot temporarily deployed to pull request September 14, 2023 18:11 Inactive
Copy link
Contributor

@vkleen vkleen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like that worked 🎉

@yannham
Copy link
Member Author

yannham commented Sep 14, 2023

Yup, sorry for the preemptive summoning!

@yannham yannham added this pull request to the merge queue Sep 14, 2023
Merged via the queue into master with commit cda06a6 Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants