Add fixtures to datadir #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turion
force-pushed
the
dev_add_fixtures_to_cabal
branch
4 times, most recently
from
8f8e619 to
0a344f7
Compare
turion
force-pushed
the
dev_add_fixtures_to_cabal
branch
from
0a344f7 to
5b5d216
Compare
ncfavier
added a commit
to NixOS/nixpkgs
that referenced
this pull request
Nov 9, 2023
idontgetoutmuch
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #256 I introduced fixture test. See NixOS/nixpkgs#262645 (comment), the fixture tests don't work if the fixtures are not added to the cabal package. I did this here.
@idontgetoutmuch @reubenharry can you review and approve?