Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #320 #322

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Fix #320 #322

merged 1 commit into from
Jan 8, 2024

Conversation

turion
Copy link
Collaborator

@turion turion commented Oct 13, 2023

  • Create lazy sampling monad transformer
  • Rename Lazy.SamplerT to Lazy.Sampler and fix other naming issues
  • Fix haddock for lazy sampler
  • Add MonadTrans instances

CC @reubenharry @idontgetoutmuch can you review?

@turion turion force-pushed the fix_320_lazy_transformer branch 3 times, most recently from 6594a07 to 9e84fbf Compare October 13, 2023 13:36
@turion turion force-pushed the fix_320_lazy_transformer branch from 9e84fbf to f8e26af Compare November 6, 2023 12:28
@turion turion force-pushed the fix_320_lazy_transformer branch from f8e26af to f63f371 Compare January 8, 2024 14:27
@turion
Copy link
Collaborator Author

turion commented Jan 8, 2024

Ping @reubenharry

reubenharry
reubenharry reviewed Jan 8, 2024
View reviewed changes
Copy link
Contributor

@reubenharry reubenharry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, these changes all seem good to me. I added independent just for pedagogical purposes, but this way is fine too.

@turion
Copy link
Collaborator Author

turion commented Jan 8, 2024

Fair enough, we can keep it.

@turion
Fix #320
9a584f6 
* Create lazy sampling monad transformer
* Rename Lazy.SamplerT to Lazy.Sampler and fix other naming issues
* Fix haddock for lazy sampler
* Add MonadTrans instances
@turion turion force-pushed the fix_320_lazy_transformer branch from f63f371 to 9a584f6 Compare January 8, 2024 16:40
@turion turion enabled auto-merge January 8, 2024 16:40
@turion turion merged commit 576d21e into master Jan 8, 2024
5 checks passed
@turion turion deleted the fix_320_lazy_transformer branch January 8, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reubenharry reubenharry reubenharry approved these changes

@idontgetoutmuch idontgetoutmuch Awaiting requested review from idontgetoutmuch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@turion @reubenharry