Skip to content
This repository has been archived by the owner on Nov 24, 2022. It is now read-only.

Remove (expected obsolete) staticsErrorMap #694

Merged
merged 3 commits into from
Jun 22, 2020

Conversation

gkaracha
Copy link
Member

This PR removes staticsErrorMap from AsteriusModule. Though small, this change eliminates data dependencies in gcSections, and thus simplifies the development of #666.

@gkaracha gkaracha requested a review from TerrorJack June 19, 2020 12:34
@gkaracha
Copy link
Member Author

@TerrorJack I can already see errors of the following form:

argv: JSException "RuntimeError: invalid index into function table\n    at wasm-function[2747]:0x91faa\n    at wasm-function[2748]:0x91fd7\n    at Scheduler.tick (file:///home/skull/tweag/a/asterius/test/argv/rts.scheduler.mjs:346:22)\n    at Immediate.<anonymous> (file:///home/skull/tweag/a/asterius/test/argv/rts.scheduler.mjs:381:29)\n    at processImmediate (internal/timers.js:456:21)"

@gkaracha gkaracha marked this pull request as draft June 19, 2020 12:45
@gkaracha
Copy link
Member Author

I'll check what happens when marshalCmmDecl returns mempty instead.

@gkaracha
Copy link
Member Author

@TerrorJack I can already see errors of the following form:

argv: JSException "RuntimeError: invalid index into function table\n    at wasm-function[2747]:0x91faa\n    at wasm-function[2748]:0x91fd7\n    at Scheduler.tick (file:///home/skull/tweag/a/asterius/test/argv/rts.scheduler.mjs:346:22)\n    at Immediate.<anonymous> (file:///home/skull/tweag/a/asterius/test/argv/rts.scheduler.mjs:381:29)\n    at processImmediate (internal/timers.js:456:21)"

Same thing happens with mempty. This needs more investigation.

@TerrorJack
Copy link
Member

@gkaracha Did you perform reboot in your dev environment? Also what's the error message given --verbose-err?

@gkaracha
Copy link
Member Author

@TerrorJack You're right, after purging everything it seems to be working just fine 👍 Let's see what the GH actions have to say.

PS. I did ./utils/reboot but I have to admit that my environment is not 100% reproducible 🙃

@gkaracha gkaracha force-pushed the wip-eliminate-statics-error-map branch from 58feff0 to 7087e77 Compare June 19, 2020 13:46
@gkaracha gkaracha marked this pull request as ready for review June 19, 2020 15:23
@gkaracha gkaracha force-pushed the wip-eliminate-statics-error-map branch from 7087e77 to a42e5d7 Compare June 19, 2020 15:47
@TerrorJack TerrorJack merged commit 2a15ae1 into master Jun 22, 2020
@TerrorJack TerrorJack deleted the wip-eliminate-statics-error-map branch June 22, 2020 17:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants