Make identity mapping optional and introduce functionality to handle unresolved dependencies #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract the different categories of dependencies in the parameters into their own lists/dicts: - non_locally_installed_deps - locally_installed_deps - user_defined_deps Define the toml-formatted user mapping from the user_defined_deps dict once Instead of manually definining the expected resolved dict of deps for each case, define a function that constructs this dict by taking advantage of the fact that the sets of deps extracted above are disjoint.
- Make identity mapping optional for the resolver function
- Add a new type of DependenciesMapping: UNRESOLVED
- Add a new default resolver for unresolved deps to create a package that:
- associates no import names (an empty set) to a dependency
- sets DependenciesMapping type to UNRESOLVED
Nour-Mws
force-pushed
the
nour/refactor-resover-tests
branch
5 times, most recently
from
e7443ab to
3725cef
Compare
5 tasks
|
Closing in favor of a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #257
The following is not relevant anymore for this PR now that we've decided to defer the discussion on whether normal users need to be able to disable the
identitymapping as a separate option. These are now tracked in #314.To do before this becomes ready for review:Add theidentity_mappingfield to settingsIf identity mapping on, log a message telling the user to turn it off for more accurate resultsAdd a different exit code for the case where there are unresolved dependenciesAdd an unresolved deps section to the human outputChange the output message for undeclared deps to make it clear that those are import names (not deps names)