docs: Better indicate include options in sass setup. #41143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's fair, easy improvement here. |
mdo
reviewed
Jan 12, 2025
| @@ -70,14 +70,15 @@ In your `custom.scss`, you'll import Bootstrap's source Sass files. You have two | |||
| @import "../node_modules/bootstrap/scss/mixins"; | |||
| @import "../node_modules/bootstrap/scss/root"; | |||
|
|
|||
| // 6. Optionally include any other parts as needed | |||
| // 6. Optionally include any other parts as needed. More includes can be found in the same directory as these examples. | |||
There was a problem hiding this comment.
Suggested change
| // 6. Optionally include any other parts as needed. More includes can be found in the same directory as these examples. | |
| // 6. Include any other optional stylesheet partials as desired; list below is not inclusive of all available stylesheets |
There was a problem hiding this comment.
Shucks, I don't have edit access so can't merge this suggestion myself.
There was a problem hiding this comment.
@mdo I've squashed in your suggestion and re-pushed!
Kelketek
force-pushed
the
fox/improve-sass-includes-instructions
branch
from
c789588 to
d558cd0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change makes a light improvement to the docs on including additional modules in Sass.
Motivation & Context
I'm in the middle of an upgrade, and I just spent the last several hours trying to track down why my custom variables for forms weren't working only to realize that the list of includes on the Sass page was not intended to be comprehensive, but only examples of sass sheets one might want to import, and that one should go through the sass directory to find any components they may yet need.
The changes I'm proposing here would have saved me a few hours, so I imagine they'll help a few other folks, too :)
Type of changes
Checklist
npm run lint)Live previews
https://deploy-preview-41143--twbs-bootstrap.netlify.app/ (Pending CI)