fix(uninstall): keep Raycast v2 data when uninstalling Raycast v1#1202
Open
adilrc wants to merge 1 commit into
Open
fix(uninstall): keep Raycast v2 data when uninstalling Raycast v1#1202adilrc wants to merge 1 commit into
adilrc wants to merge 1 commit into
Conversation
find_app_files() and find_app_system_files() collect any *raycast* directory when uninstalling com.raycast.macos. The substring match also caught com.raycast-x.macos.* (a separate product line), including its .backups recovery siblings, removing data that is not a v1 leftover. Skip basenames matching *raycast-x* (case-insensitive) in each of the three Raycast collection loops. The trigger and the *raycast* sweep are unchanged.
adilrc
changed the title
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When uninstalling Raycast v1 (
com.raycast.macos), Mole is also deleting Raycast v2 data (com.raycast-x.macos).This is a consequence of #404, which implemented sweeping everything matching *raycast*.
Summary
The fix skips any basename matching raycast-x in each of the Raycast collection loops.
Safety Review
Yes, uninstall
No
Raycast v1 uninstall no longer touches
com.raycast-x.macos.*directories which match Raycast v2 bundle ID.Tests
bash -n lib/core/app_protection.sh and ./scripts/check.sh --formatpassSafety-related changes
Narrows Raycast v1 uninstall to stop deleting the separate
com.raycast-x.macos.*