Fixing "TypeError" to some inputs #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the token was an empty or some random input with less than 39 chars, `bufferpack.unpack` method was returning `undefined` - breaking the `Array.shift` used to get the version, timestamp and nonce - throwing "TypeError: Cannot read property 'shift' of undefined"error. This commit adds a guard clause to this TypeError and a more descriptive error message.
ricardohbin
force-pushed
the
fix-shift-of-undefined
branch
from
15c1f83
to
2d4651f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the token was an empty or some random input with less than 39 chars,
bufferpack.unpackmethod was returningundefined- breaking theArray.shiftused to get the version, timestamp and nonce - throwing "TypeError: Cannot read property 'shift' of undefined"error.This commit adds a guard clause to this TypeError and a more descriptive error message.