Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: blurry toasts #6

Merged
merged 2 commits into from
Apr 1, 2024
Merged

fix: blurry toasts #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8078620
fix: blurry toasts
tutkli Apr 1, 2024
ce3a882
test: update tests
tutkli Apr 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion libs/ngx-sonner/src/lib/toast.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,9 @@ export class ToastComponent implements AfterViewInit, OnDestroy {
effect(() => {
const heightIndex = this.heightIndex();
const toastsHeightBefore = this.toastsHeightBefore();
untracked(() => this.offset.set(heightIndex * GAP + toastsHeightBefore));
untracked(() =>
this.offset.set(Math.round(heightIndex * GAP + toastsHeightBefore))
);
});

effect(() => {
Expand Down
8 changes: 4 additions & 4 deletions libs/ngx-sonner/src/tests/toaster.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,17 +44,17 @@ describe('Toaster', () => {

it('should show a toast with custom duration', async () => {
const { user, trigger, queryByText, detectChanges } = await setup({
cb: toast => toast('Hello world', { duration: 300 }),
cb: toast => toast('Custom duration', { duration: 300 }),
});

expect(queryByText('Hello world')).toBeNull();
expect(queryByText('Custom duration')).toBeNull();

await user.click(trigger);
expect(queryByText('Hello world')).not.toBeNull();
expect(queryByText('Custom duration')).not.toBeNull();

await sleep(500);
detectChanges();
expect(queryByText('Hello world')).toBeNull();
expect(queryByText('Custom duration')).toBeNull();
});

it('should reset duration on a toast update', async () => {
Expand Down
Loading