Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prioritize toast position over toaster's #26

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Conversation

tutkli
Copy link
Owner

@tutkli tutkli commented Aug 23, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Toaster position is always used to determine a toast position.

Closes #23

What is the new behavior?

Toast individual position is prioritized over the toaster position.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@tutkli tutkli merged commit 77c5cb6 into master Aug 23, 2024
2 checks passed
@tutkli
Copy link
Owner Author

tutkli commented Aug 23, 2024

🎉 This PR is included in version 2.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Position inconsistency
1 participant