Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent toasts to be swiped out when not dismissible #16

Merged
merged 5 commits into from
Apr 16, 2024

Conversation

tutkli
Copy link
Owner

@tutkli tutkli commented Apr 16, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Toasts configured with dismissible: false can be swiped out.

Closes #

What is the new behavior?

  • Toast dismissable field has been renamed to dismissible.
  • Toasts can't be swiped out when dismissible is set to false.

Does this PR introduce a breaking change?

  • Yes
  • No
  • Toast dismissable field has been renamed to dismissible.

Other information

@tutkli tutkli merged commit 6cd1e93 into master Apr 16, 2024
2 checks passed
@tutkli tutkli deleted the bug/dismissible branch April 16, 2024 10:45
@tutkli
Copy link
Owner Author

tutkli commented Apr 16, 2024

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant