-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sdk] Key resolution #7069
Open
paw-hub
wants to merge
17
commits into
sdk-integration-branch
Choose a base branch
from
6956-key-resolution
base: sdk-integration-branch
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[sdk] Key resolution #7069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paw-hub
force-pushed
the
6956-key-resolution
branch
4 times, most recently
from
June 5, 2024 07:38
0e724f8
to
df769f9
Compare
Unfortunately it's an enum variant, so a macro is necessary.
Once we get concrete Rust types, this will not be necessary.
|
paw-hub
force-pushed
the
6956-key-resolution
branch
4 times, most recently
from
June 11, 2024 08:06
05a7005
to
439aef4
Compare
paw-hub
force-pushed
the
6956-key-resolution
branch
3 times, most recently
from
June 19, 2024 11:33
c60284d
to
cf69571
Compare
charlag
force-pushed
the
sdk-integration-branch
branch
from
June 19, 2024 11:35
844d5ef
to
c9f6e7b
Compare
paw-hub
force-pushed
the
6956-key-resolution
branch
3 times, most recently
from
June 19, 2024 13:05
bdf4836
to
ea24058
Compare
paw-hub
force-pushed
the
6956-key-resolution
branch
from
June 19, 2024 13:12
ea24058
to
9070f59
Compare
paw-hub
force-pushed
the
6956-key-resolution
branch
2 times, most recently
from
June 20, 2024 12:26
f75953f
to
684b6bb
Compare
charlag
reviewed
Jun 20, 2024
rezbyte
reviewed
Jun 25, 2024
rezbyte
reviewed
Jun 25, 2024
rezbyte
reviewed
Jun 25, 2024
rezbyte
reviewed
Jun 25, 2024
rezbyte
reviewed
Jun 25, 2024
rezbyte
reviewed
Jun 25, 2024
Co-authored by: jat <[email protected]>
I am rebasing this branch against the sdk integration branch. |
Co-authored by: jat <[email protected]>
rezbyte
force-pushed
the
6956-key-resolution
branch
2 times, most recently
from
June 25, 2024 15:48
e6c6c3c
to
1a875e2
Compare
Co-authored by: jat <[email protected]> Co-authored by: mup <[email protected]>
rezbyte
force-pushed
the
6956-key-resolution
branch
2 times, most recently
from
June 27, 2024 11:21
68ecae5
to
d2f0a79
Compare
rezbyte
reviewed
Jun 27, 2024
rezbyte
force-pushed
the
6956-key-resolution
branch
from
June 28, 2024 10:17
4cc37ff
to
db5acdc
Compare
We renamed our `date` struct to avoid a name collision in the generated uniffi bindings. Co-authored-by: ivk <[email protected]>
Co-authored-by: paw <[email protected]>
Co-authored-by: paw <[email protected]>
rezbyte
force-pushed
the
6956-key-resolution
branch
from
July 1, 2024 12:28
7286462
to
4358a36
Compare
Avoid having to wrap all Id types in this. Co-authored-by: paw <[email protected]>
Co-authored-by: paw <[email protected]>
Co-authored-by: paw <[email protected]>
Co-authored-by: paw <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6956