Handle async index db initialization errors, fixes tutadb 1805 #7068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Errors while initializing the DBFacade are now handled inside DBFacade and re thrown as DBError to prevent uncaught errors. Errors from the event queue are also not reported as uncaught error by EntityClient anymore as they are thrown anyway.
bedhub
force-pushed
the
1805-tutadb-handle-db-initialization-errors
branch
from
b4202bd
to
b39833d
Compare
charlag
reviewed
Jun 27, 2024
| @@ -86,11 +86,11 @@ export class DbFacade { | |||
| } | |||
| } | |||
|
|
|||
| DBOpenRequest.onupgradeneeded = (event: IDBVersionChangeEvent) => { | |||
| DBOpenRequest.onupgradeneeded = async (event: IDBVersionChangeEvent) => { | |||
There was a problem hiding this comment.
This callback is not async and I think we'll have problems if we try to assume it's async.
I wonder if we can block it here Atomics.wait() somehow, probably not without another worker?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Errors while initializing the DBFacade are now handled inside DBFacade and re thrown as DBError to prevent uncaught errors.
Errors from the event queue are also not reported as uncaught error by EntityClient anymore as they are thrown anyway.