Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: GitHub action workflows use node version from .nvmrc #6828

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kunalnagar
Copy link
Contributor

@kunalnagar kunalnagar commented Apr 4, 2024

  • Instead of updating node versions across multiple files, you only need to update the .nvmrc and the same version will be picked up by GitHub actions.
  • Matrix strategy testing was only using one version of node. Instead, updated it to pick up the version from the .nvmrc. In the future, if Tuta needs to be matrix tested, multiple node versions can be used.

@kunalnagar kunalnagar marked this pull request as ready for review April 4, 2024 19:04
@kunalnagar kunalnagar changed the title chore: Update GitHub action workflows to use node version from .nvmrc chore: GitHub action workflows use node version from .nvmrc Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant