-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ios] Use build script for libcrypto #6645
Conversation
Still some remaining questions:
|
389e34b
to
bb1866d
Compare
This seems to work well enough now that it can be reviewed. That said, on our Mac Mini with Apple Silicon, initial builds take around 78 seconds longer due to having to compile OpenSSL three times (iOS on arm64 and iOS-Simulator on arm64/x86_64). This isn't an issue for developers, since it only has to do this task once and subsequent builds are instant, but for making releases, is this an issue? Release builds already take a while, so it's not that much longer (relatively). We can probably improve this with some sort of caching (as @rezbyte suggested) if it's worth it. |
62e35e3
to
1c578a5
Compare
Set up a submodule that tracks external build tools, and have a script automatically compile libcrypto for iOS Simulator (arm64/x86_64) and iOS (arm64). Stop tracking the libcrypto binary in git. Also stop using a .xcframework and just conditionally static-link the .a files depending on architecture, and use the include directory from the build tools. Fixes #6603
We can tell the builder to not wipe the repo if that helps. I think this isn't a bit issue |
We probably need some test notes |
Closed because we're removing libcrypto via #7344 |
Set up a submodule that tracks external build tools, and have a script automatically compile libcrypto for iOS Simulator (arm64/x86_64) and iOS (arm64).
Stop tracking the libcrypto binary in git.
Also stop using a .xcframework and just conditionally static-link the .a files depending on architecture, and use the include directory from the build tools.
Fixes #6603