-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] Biome formatter #6248
base: master
Are you sure you want to change the base?
[ci] Biome formatter #6248
Conversation
Cool! Although long lines are really a mixed bag. My biggest concern is that Prettier is integrated into Webstorm nicely and for Biome we have to install it additionally: |
that's also only compatible with webstorm >= 2023.2. we're still on 2023.1 |
a1a9d1f
to
bdb8edb
Compare
what I hear is that we have finally an excuse to update |
bdb8edb
to
318c678
Compare
comparison of our error lint rules and biomes available ruleshttps://eslint.org/docs/latest/rules/
|
318c678
to
09b13fe
Compare
3bc468b
to
e0084fd
Compare
updated for biome 1.5.1. biome now has one more previously missing lint rule (no-global-assign) and the current intelliJ plugin nightly build supports format-on-save https://plugins.jetbrains.com/plugin/22761-biome/versions/nightly/461235 |
e0084fd
to
90fe14d
Compare
90fe14d
to
1c3f3a6
Compare
it's not a 100% drop-in, but it's like a hundred times faster.
biome has a list of ignored files it will not touch and will be noisy when explicitly given these files, which is bad for our pre-commit hook. also doesn't call biome if there's nothing left after filtering out ignored files. this is deliberately not sending the error output to /dev/null so we can see if something really is going wrong.
1c3f3a6
to
18741f6
Compare
No description provided.