Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display boost visibility (#4953) #4963

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Exagone313
Copy link
Contributor

Closes #4953

Comment on lines +88 to +89
<string name="post_boosted_unlisted_format">%1$s boosted (Unlisted)</string>
<string name="post_boosted_private_format">%1$s boosted (Followers-Only)</string>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure about those strings

I suggest also:

Suggested change
<string name="post_boosted_unlisted_format">%1$s boosted (Unlisted)</string>
<string name="post_boosted_private_format">%1$s boosted (Followers-Only)</string>
<string name="post_boosted_unlisted_format">%1$s quietly boosted</string>
<string name="post_boosted_private_format">%1$s privately boosted</string>

@connyduck
Copy link
Collaborator

Yeah, so, I'm afraid that displaying it with the StatusDetailedViewHolder is probably a lot more complicated

  • Forward the id of the boost instead of the actual post to the ViewThreadActivity, everywhere it is opened
  • adjust the logic to handle boosts
  • Add an additional view to display the info

@Exagone313 Exagone313 marked this pull request as draft March 2, 2025 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show boost visibility
2 participants